src: retrieve binding data from the context#33139
Closed
addaleax wants to merge 5 commits intonodejs:masterfrom
Closed
src: retrieve binding data from the context#33139addaleax wants to merge 5 commits intonodejs:masterfrom
addaleax wants to merge 5 commits intonodejs:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is mostly taken from the common subset of #32761 and #32984, with a few modifications on top of it (notably,
BindingDatadoes not make sense as a class any longer and can be replaced byBaseObjectdirectly).Instead of passing them through the data bound to function
templates, store references to them in a list embedded inside
the context, and store the integer index
(which is context-independent) in the function template data.
This makes the function templates more context-independent,
and makes it possible to embed binding data in non-main contexts.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes